Detect occurrences of the comma operator in expressions. The comma operator can make code harder to read and debug, as it executes two expressions but only returns the last one. Suggest alternative structures for better readability.
The comma operator executes two expressions and returns the result of the second one, which can make the code confusing and harder to debug. It reduces readability and reliability, and the same outcome can be achieved with clearer alternatives.
Side-by-side examples engineers can pattern-match during review.
i = a += 2, a + b; // Noncompliant: What's the value of i ?a += 2;
i = a + b; // We probably expected to assign the result of the addition to i, although the previous code wasn't doing it.i = a += 2, a + b; // Noncompliant: What's the value of i ?a += 2;
i = a + b; // We probably expected to assign the result of the addition to i, although the previous code wasn't doing it.From the same buckets as this rule.
Check if loops use equality operators (== or !=) in termination conditions. These can lead to infinite loops if the condition is never met exactly. Instead, use relational operators like < or > for safer loop termination.